Skip to content

rm chainlink-aptos import by using codec module#23065

Merged
jmank88 merged 1 commit into
developfrom
rm-aptos-dep
Jul 10, 2026
Merged

rm chainlink-aptos import by using codec module#23065
jmank88 merged 1 commit into
developfrom
rm-aptos-dep

Conversation

@jmank88

@jmank88 jmank88 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

This PR removes the (direct) import of chainlink-aptos, by completing the switch to use the codec module instead.

Notice there is still an indirect import due to chainlink-sui depending on aptos.

Requires:

@jmank88 jmank88 mentioned this pull request Jul 9, 2026
Merged
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@jmank88 jmank88 requested a review from pavel-raykov July 9, 2026 15:36
pavel-raykov
pavel-raykov previously approved these changes Jul 9, 2026
View reviewed changes
@trunk-io

trunk-io Bot commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Static Badge   Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

JohnChangUK
JohnChangUK previously approved these changes Jul 9, 2026
View reviewed changes
@jmank88 jmank88 dismissed stale reviews from JohnChangUK and pavel-raykov via 23de076 July 9, 2026 17:36
@jmank88 jmank88 marked this pull request as ready for review July 9, 2026 17:37
@jmank88 jmank88 requested review from a team as code owners July 9, 2026 17:37
@jmank88 jmank88 enabled auto-merge July 9, 2026 17:37
@jmank88 jmank88 requested review from a team as code owners July 9, 2026 17:58
@github-actions

github-actions Bot commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

CORA - Analysis Skipped

Reason: The number of code owners (4) is less than the minimum required (5) and/or the number of CODEOWNERS entries with changed files (5) is less than the minimum required (2).

JohnChangUK
JohnChangUK previously approved these changes Jul 9, 2026
View reviewed changes
@jmank88 jmank88 requested a review from ogtownsend July 9, 2026 18:55
pavel-raykov
pavel-raykov previously approved these changes Jul 9, 2026
View reviewed changes
@jmank88 jmank88 requested a review from KodeyThomas July 9, 2026 19:20
ogtownsend
ogtownsend previously approved these changes Jul 9, 2026
View reviewed changes
@jmank88 jmank88 added this pull request to the merge queue Jul 9, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Jul 9, 2026
@jmank88 jmank88 dismissed stale reviews from ogtownsend, pavel-raykov, and JohnChangUK via 1b8e5e4 July 9, 2026 20:34
@jmank88 jmank88 enabled auto-merge July 9, 2026 20:34
@jmank88

jmank88 commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Strange unit test failure left behind 🤔
WASM test but db tx failure that is repeatable. And I can't run the tests locally for some reason
Edit: Rebase fixed it 🤷

@jmank88 jmank88 mentioned this pull request Jul 10, 2026
Closed
@cl-sonarqube-production

cl-sonarqube-production Bot commented Jul 10, 2026

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
1 New issue
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@jmank88 jmank88 added this pull request to the merge queue Jul 10, 2026
Merged via the queue into develop with commit 5b4ddf7 Jul 10, 2026
251 of 283 checks passed
@jmank88 jmank88 deleted the rm-aptos-dep branch July 10, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kalverra kalverra kalverra approved these changes
@ogtownsend ogtownsend ogtownsend approved these changes
@carte7000 carte7000 Awaiting requested review from carte7000 carte7000 is a code owner automatically assigned from smartcontractkit/ccip-offchain
@matYang matYang Awaiting requested review from matYang matYang is a code owner automatically assigned from smartcontractkit/ccip-offchain
@makramkd makramkd Awaiting requested review from makramkd makramkd is a code owner automatically assigned from smartcontractkit/ccip-offchain
@AmrMohamedRezk AmrMohamedRezk Awaiting requested review from AmrMohamedRezk AmrMohamedRezk is a code owner automatically assigned from smartcontractkit/ccip-offchain
@agusaldasoro agusaldasoro Awaiting requested review from agusaldasoro agusaldasoro is a code owner automatically assigned from smartcontractkit/ccip-offchain
@tt-cll tt-cll Awaiting requested review from tt-cll tt-cll is a code owner automatically assigned from smartcontractkit/ccip-offchain
@chris-de-leon-cll chris-de-leon-cll Awaiting requested review from chris-de-leon-cll chris-de-leon-cll is a code owner automatically assigned from smartcontractkit/ccip-offchain
@Tofel Tofel Awaiting requested review from Tofel
@KodeyThomas KodeyThomas Awaiting requested review from KodeyThomas
@JohnChangUK JohnChangUK Awaiting requested review from JohnChangUK
@pavel-raykov pavel-raykov Awaiting requested review from pavel-raykov

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jmank88 @kalverra @JohnChangUK @ogtownsend @pavel-raykov